Skip to content

Conversation

@allenwang28
Copy link
Contributor

@allenwang28 allenwang28 commented Sep 3, 2025

In pursuit of: #16

this will make it so that applications no longer have to create a MultiProcessStore and pass it everywhere:

from torchstore import MultiProcessStore

store = MultiProcessStore.create_store()

my_actor = spawn_actors(MyActor, store, ...)

instead any actor can simply call

import torchstore as store

store.put(...)
store.get(...)

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 3, 2025
logger = getLogger(__name__)


assert os.environ.get("HF_TOKEN", None) is not None, "HF_TOKEN must be set"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note, you shouldn't need this if you hf auth login.

@casteryh
Copy link
Contributor

casteryh commented Sep 3, 2025

I think it make more sense to do this in a submodule, so something like

from torchstore import torchstore as ts

instead of doing it at the top level.
Making this change should be trivial though.

@LucasLLC
Copy link
Contributor

LucasLLC commented Sep 6, 2025

This idea was so great, and it came right in time because it made https://github.com/meta-pytorch/torchstore/pull/19 much easier. I'm closing in favor of that PR, but greatly appreciate the contribution!

@LucasLLC LucasLLC closed this Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants