-
Notifications
You must be signed in to change notification settings - Fork 5
make torchstore api concurrent safe #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
casteryh
wants to merge
13
commits into
main
Choose a base branch
from
yhu/concurrent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+224
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a robust concurrency control mechanism for RDMA operations in TorchStore by adding an asynchronous executor and refactoring the codebase to ensure safe, sequential execution of RDMA requests. The changes also update client and storage interfaces to support this executor, improve error handling, and clarify environment variable defaults.
Concurrency and RDMA execution improvements:
OnceCell
andSequentialExecutor
classes intorchstore/_async_utils.py
to provide async initialization and sequential execution for RDMA tasks, ensuring only one RDMA operation runs at a time.LocalClient
and storage classes to accept and useSequentialExecutor
for RDMA operations, including passing the executor through all relevant layers and enforcing concurrency limits via a semaphore and method decorator. [1] [2] [3] [4] [5] [6] [7] [8] [9]API and initialization changes:
torchstore/api.py
to useOnceCell[LocalClient]
for lazy, single initialization and refactored related functions to support this pattern. [1] [2] [3]Transport buffer interface updates:
TransportBuffer
andRDMATransportBuffer
to require an executor for RDMA read/write operations, enforcing sequential execution and updating method signatures. [1] [2] [3] [4]Configuration and minor fixes:
TORCHSTORE_RDMA_ENABLED
environment variable to"1"
, enabling RDMA by default.These changes collectively ensure safe and efficient RDMA usage in TorchStore, improve initialization and resource management, and lay groundwork for future scalability.