Dont prefix examples as test #1019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: These functions are sample AppDef generators used for tests, not tests itself. Following python convension, these shouldn't be named `test_` which is reserved for actual tests. Frameworks often assume that top level `test_` functions are actual unit tests, leading to failures like https://github.com/pytorch/torchx/actions/runs/13956345042/job/39068272186 Differential Revision: D71526823
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71526823 |
lgarg26
approved these changes
Mar 23, 2025
facebook-github-bot
merged commit 24550f4
into
meta-pytorch:main
17 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These functions are sample AppDef generators used for tests, not tests itself.
Following python convension, these shouldn't be named
test_which is reserved for actual tests.Frameworks often assume that top level
test_functions are actual unit tests, leading to failures like https://github.com/pytorch/torchx/actions/runs/13956345042/job/39068272186Differential Revision: D71526823