(torchx-fb/named_resources) semi-automate registration of fractional resources for gpu types #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D82594325. |
facebook-github-bot
force-pushed
the
export-D82594325
branch
from
eef90a2 to
fa4c3da
Compare
Contributor
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D82594325. |
highker
approved these changes
Sep 18, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
…togenerate aliases and fractionals, migrate zion_4s_80g to use it. (#1121) Summary: Context: D82556202 ``` named_resource(aliases=["zion4s_80g"], fractionals=powers_of_two_gpus) def zion_4s_80g(fractional: float = 1.0) -> Resource: ... ``` Registers the named resources: 1. `zion_4s_80g` and the alias `zion4s_80g` 1. `zion_4s_80g_1 == zion_4s_80g(fractional=EIGHTH)` 1. `zion_4s_80g_2 == zion_4s_80g(fractional=QUARTER)` 1. `zion_4s_80g_4 == zion_4s_80g(fractional=HALF)` 1. `zion_4s_80g_8 == zion_4s_80g(fractional=WHOLE)` so that we don't have to manually do this. The auto-generated fractionals will return `True` when: ``` from torchx.specs.fb.resource import is_fractional from torchx.specs import get_named_resource assert is_fractional(get_named_resource("zion_4s_80g_1")) == True assert is_fractional(get_named_resource("zion_4s_80g_2")) == True assert is_fractional(get_named_resource("zion_4s_80g_4")) == True assert is_fractional(get_named_resource("zion_4s_80g_8")) == True assert is_fractional(get_named_resource("zion_4s_80g")) == False ``` NOTE: each of the fractional types (including WHOLE) will have `resource.capabilities[IS_FRACTIONAL] == True` so that we can use it as a way to determine whether a resource originates from a fractional named resource. Reviewed By: ajauhri, highker Differential Revision: D82594325
facebook-github-bot
force-pushed
the
export-D82594325
branch
from
fa4c3da to
b413425
Compare
Contributor
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D82594325. |
…togenerate aliases and fractionals, migrate zion_4s_80g to use it. (#1121) Summary: Context: D82556202 ``` named_resource(aliases=["zion4s_80g"], fractionals=powers_of_two_gpus) def zion_4s_80g(fractional: float = 1.0) -> Resource: ... ``` Registers the named resources: 1. `zion_4s_80g` and the alias `zion4s_80g` 1. `zion_4s_80g_1 == zion_4s_80g(fractional=EIGHTH)` 1. `zion_4s_80g_2 == zion_4s_80g(fractional=QUARTER)` 1. `zion_4s_80g_4 == zion_4s_80g(fractional=HALF)` 1. `zion_4s_80g_8 == zion_4s_80g(fractional=WHOLE)` so that we don't have to manually do this. The auto-generated fractionals will return `True` when: ``` from torchx.specs.fb.resource import is_fractional from torchx.specs import get_named_resource assert is_fractional(get_named_resource("zion_4s_80g_1")) == True assert is_fractional(get_named_resource("zion_4s_80g_2")) == True assert is_fractional(get_named_resource("zion_4s_80g_4")) == True assert is_fractional(get_named_resource("zion_4s_80g_8")) == True assert is_fractional(get_named_resource("zion_4s_80g")) == False ``` NOTE: each of the fractional types (including WHOLE) will have `resource.capabilities[IS_FRACTIONAL] == True` so that we can use it as a way to determine whether a resource originates from a fractional named resource. Reviewed By: ajauhri, highker Differential Revision: D82594325
kiukchung
force-pushed
the
export-D82594325
branch
from
b413425 to
bbe1c23
Compare
Contributor
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D82594325. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: D82556202
Creates:
def zion_4s_80g_1(): return zion_4s_80g(fractional=EIGHTH)zion_4s_80g_2(): return zion_4s_80g(fractional=QUARTER)zion_4s_80g_4(): return zion_4s_80g(fractional=HALF)zion_4s_80g_8(): return zion_4s_80g(fractional=WHOLE)so that we don't have to manually do this
NOTE: each of the fractional types (including WHOLE) will have
resource.capabilities[IS_FRACTIONAL] == Trueso that we can use it as a way to determine whether a resource originates from a fractional named resource.Reviewed By: ajauhri
Differential Revision: D82594325