import Workspace from torchx.specs not torchx.workspace #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84628206. |
Summary: `Workspace` class moved from `torchx.workspace` to `torchx.specs` to accomodate the new `Role.workspace` attribute in #1139. This diff removes the re-export of `Workspace` from `torchx.workspace` and changes import-sites to correctly import `Workspace` from `torchx.specs` Differential Revision: D84628206
facebook-github-bot
force-pushed
the
export-D84628206
branch
from
4264a6a to
7ec5819
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
==========================================
- Coverage 91.65% 91.65% -0.01%
==========================================
Files 83 83
Lines 6481 6480 -1
==========================================
- Hits 5940 5939 -1
Misses 541 541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Workspaceclass moved fromtorchx.workspacetotorchx.specsto accomodate the newRole.workspaceattribute in #1139.This diff removes the re-export of
Workspacefromtorchx.workspaceand changes import-sites to correctly importWorkspacefromtorchx.specsDifferential Revision: D84628206