Introduce StructuredRunOpt for more complex runopts #1154
+126
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 21, 2025
Summary:
StructuredRunOpt can be used to create new complex runopts
This can be used as for example:
```
dataclass
class UlimitTest(StructuredRunOpt):
name: str
hard: int
soft: int
def template(self) -> str:
return "{name},{soft:d},{hard:d}"
```
This comes with
1. template() that helps the from_repr() use that template to map to the fields with types
2. __eq__ to check equality between two
Differential Revision: D85159071
AbishekS
force-pushed
the
export-D85159071
branch
from
48d5c7d to
2bf5da2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1154 +/- ##
==========================================
- Coverage 91.61% 91.60% -0.01%
==========================================
Files 84 84
Lines 6644 6661 +17
==========================================
+ Hits 6087 6102 +15
- Misses 557 559 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 27, 2025
Summary:
StructuredRunOpt can be used to create new complex runopts
This can be used as for example:
```
dataclass
class UlimitTest(StructuredRunOpt):
name: str
hard: int
soft: int
def template(self) -> str:
return "{name},{soft:d},{hard:d}"
```
This comes with
1. template() that helps the from_repr() use that template to map to the fields with types
2. __eq__ to check equality between two
Differential Revision: D85159071
AbishekS
force-pushed
the
export-D85159071
branch
from
2bf5da2 to
7b74ccf
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 28, 2025
Summary:
StructuredRunOpt can be used to create new complex runopts
This can be used as for example:
```
dataclass
class UlimitTest(StructuredRunOpt):
name: str
hard: int
soft: int
def template(self) -> str:
return "{name},{soft:d},{hard:d}"
```
This comes with
1. template() that helps the from_repr() use that template to map to the fields with types
2. __eq__ to check equality between two
Differential Revision: D85159071
AbishekS
force-pushed
the
export-D85159071
branch
from
7b74ccf to
9d6822b
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 28, 2025
Summary:
StructuredRunOpt can be used to create new complex runopts
This can be used as for example:
```
dataclass
class UlimitTest(StructuredRunOpt):
name: str
hard: int
soft: int
def template(self) -> str:
return "{name},{soft:d},{hard:d}"
```
This comes with
1. template() that helps the from_repr() use that template to map to the fields with types
2. __eq__ to check equality between two
Differential Revision: D85159071
AbishekS
force-pushed
the
export-D85159071
branch
from
9d6822b to
dec9777
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 28, 2025
Summary:
StructuredRunOpt can be used to create new complex runopts
This can be used as for example:
```
dataclass
class UlimitTest(StructuredRunOpt):
name: str
hard: int
soft: int
def template(self) -> str:
return "{name},{soft:d},{hard:d}"
```
This comes with
1. template() that helps the from_repr() use that template to map to the fields with types
2. __eq__ to check equality between two
Add this new type to CfgVal's acceptable types.
Also modify a piece of code that could use CfgVal instead of typing out entire list of types in.
https://www.internalfb.com/code/fbsource/[37f968940832a633afa761e829e81184858cf6b8]/fbcode/msl/experimental/training_execution_environment/monarch_backend/api/launch_cluster.py?lines=196-199
Differential Revision: D85159071
AbishekS
force-pushed
the
export-D85159071
branch
from
dec9777 to
899d3a4
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 28, 2025
Summary:
StructuredRunOpt can be used to create new complex runopts
This can be used as for example:
```
dataclass
class UlimitTest(StructuredRunOpt):
name: str
hard: int
soft: int
def template(self) -> str:
return "{name},{soft:d},{hard:d}"
```
This comes with
1. template() that helps the from_repr() use that template to map to the fields with types
2. __eq__ to check equality between two
Add this new type to CfgVal's acceptable types.
Also modify a piece of code that could use CfgVal instead of typing out entire list of types in.
https://www.internalfb.com/code/fbsource/[37f968940832a633afa761e829e81184858cf6b8]/fbcode/msl/experimental/training_execution_environment/monarch_backend/api/launch_cluster.py?lines=196-199
Differential Revision: D85159071
AbishekS
force-pushed
the
export-D85159071
branch
from
899d3a4 to
c6378f3
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 28, 2025
Summary:
StructuredRunOpt can be used to create new complex runopts
This can be used as for example:
```
dataclass
class UlimitTest(StructuredRunOpt):
name: str
hard: int
soft: int
def template(self) -> str:
return "{name},{soft:d},{hard:d}"
```
This comes with
1. template() that helps the from_repr() use that template to map to the fields with types
2. __eq__ to check equality between two
Add this new type to CfgVal's acceptable types.
Also modify a piece of code that could use CfgVal instead of typing out entire list of types in.
https://www.internalfb.com/code/fbsource/[37f968940832a633afa761e829e81184858cf6b8]/fbcode/msl/experimental/training_execution_environment/monarch_backend/api/launch_cluster.py?lines=196-199
Differential Revision: D85159071
AbishekS
force-pushed
the
export-D85159071
branch
from
c6378f3 to
bd885ad
Compare
Summary:
StructuredRunOpt can be used to create new complex runopts
This can be used as for example:
```
dataclass
class UlimitTest(StructuredRunOpt):
name: str
hard: int
soft: int
def template(self) -> str:
return "{name},{soft:d},{hard:d}"
```
This comes with
1. template() that helps the from_repr() use that template to map to the fields with types
2. __eq__ to check equality between two
Add this new type to CfgVal's acceptable types.
Also modify a piece of code that could use CfgVal instead of typing out entire list of types in.
https://www.internalfb.com/code/fbsource/[37f968940832a633afa761e829e81184858cf6b8]/fbcode/msl/experimental/training_execution_environment/monarch_backend/api/launch_cluster.py?lines=196-199
Reviewed By: kiukchung
Differential Revision: D85159071
AbishekS
force-pushed
the
export-D85159071
branch
from
bd885ad to
f8f251b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
StructuredRunOpt can be used to create new complex runopts
This can be used as for example:
This comes with
Differential Revision: D85159071