Skip to content

Conversation

@ishachirimar
Copy link
Contributor

@ishachirimar ishachirimar commented Apr 12, 2024

Summary:
Add the start epoch time to the TorchXEvent class.

Reviewed By: Sanjay-Ganeshan

Differential Revision: D56037935

Summary:
Add the start epoch time to the TorchXEvent class. 

this doesn't modify the scuba logs yet, D56037445 needs to be approved first to add to TSMLogEntry

Reviewed By: Sanjay-Ganeshan

Differential Revision: D56037935
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56037935

Copy link
Contributor

@Sanjay-Ganeshan Sanjay-Ganeshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manav-a manav-a self-requested a review April 15, 2024 15:20
@facebook-github-bot facebook-github-bot merged commit a38a1f8 into meta-pytorch:main Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants