Allow field path env variables #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59865500 |
Sanjay-Ganeshan
approved these changes
Jul 19, 2024
Contributor
Sanjay-Ganeshan
left a comment
Sanjay-Ganeshan
left a comment
There was a problem hiding this comment.
LGTM - let's add a comment above the constant value
ndacosta
added a commit
to ndacosta/torchx
that referenced
this pull request
Jul 19, 2024
Summary: Pull Request resolved: meta-pytorch#935 # Context Currently the kubernetes scheduler translate all the env of the role into something like this. ``` - name: FOO value: bar ``` In some cases we may also need env variables of type: ``` - name: FOO valueFrom: fieldRef: fieldPath: bar.path ``` This diff adds the ability to specify env in the role that will be translated to the second option. # Changes - Create constant placeholder to insert in the value of env in roles if we want them to be translated to the second option - If placeholder is present in the value, convert to code below stripping the placeholder ``` V1EnvVar( name=key, value_from=V1EnvVarSource( field_ref=V1ObjectFieldSelector(field_path=value) ), ) ``` if not, translate to ``` V1EnvVar(name=key, value=value) ``` - update tests Reviewed By: Sanjay-Ganeshan Differential Revision: D59865500
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59865500 |
ndacosta
force-pushed
the
export-D59865500
branch
from
0706acf to
1e7dae9
Compare
ndacosta
added a commit
to ndacosta/torchx
that referenced
this pull request
Jul 19, 2024
Summary: Pull Request resolved: meta-pytorch#935 # Context Currently the kubernetes scheduler translate all the env of the role into something like this. ``` - name: FOO value: bar ``` In some cases we may also need env variables of type: ``` - name: FOO valueFrom: fieldRef: fieldPath: bar.path ``` This diff adds the ability to specify env in the role that will be translated to the second option. # Changes - Create constant placeholder to insert in the value of env in roles if we want them to be translated to the second option - If placeholder is present in the value, convert to code below stripping the placeholder ``` V1EnvVar( name=key, value_from=V1EnvVarSource( field_ref=V1ObjectFieldSelector(field_path=value) ), ) ``` if not, translate to ``` V1EnvVar(name=key, value=value) ``` - update tests Reviewed By: Sanjay-Ganeshan Differential Revision: D59865500
ndacosta
force-pushed
the
export-D59865500
branch
from
1e7dae9 to
590f829
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59865500 |
Summary: Pull Request resolved: meta-pytorch#935 # Context Currently the kubernetes scheduler translate all the env of the role into something like this. ``` - name: FOO value: bar ``` In some cases we may also need env variables of type: ``` - name: FOO valueFrom: fieldRef: fieldPath: bar.path ``` This diff adds the ability to specify env in the role that will be translated to the second option. # Changes - Create constant placeholder to insert in the value of env in roles if we want them to be translated to the second option - If placeholder is present in the value, convert to code below stripping the placeholder ``` V1EnvVar( name=key, value_from=V1EnvVarSource( field_ref=V1ObjectFieldSelector(field_path=value) ), ) ``` if not, translate to ``` V1EnvVar(name=key, value=value) ``` - update tests Reviewed By: Sanjay-Ganeshan Differential Revision: D59865500
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59865500 |
ndacosta
force-pushed
the
export-D59865500
branch
from
590f829 to
dc8eefd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Currently the kubernetes scheduler translate all the env of the role into something like this.
In some cases we may also need env variables of type:
This diff adds the ability to specify env in the role that will be translated to the second option.
Changes
if not, translate to
Differential Revision: D59865500