Add appdef metadata to torchx event #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61632621 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61632621 |
zackycao
added a commit
to zackycao/torchx
that referenced
this pull request
Aug 21, 2024
Summary: Pull Request resolved: meta-pytorch#947 Add appdef metadata to torchx event class. Scuba logs does not get modified yet. Differential Revision: D61632621
zackycao
force-pushed
the
export-D61632621
branch
from
eed8ebd to
909e06b
Compare
andywag
approved these changes
Aug 22, 2024
Contributor
andywag
left a comment
andywag
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61632621 |
zackycao
added a commit
to zackycao/torchx
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: meta-pytorch#947 Add appdef metadata to torchx event class. Scuba logs does not get modified yet. The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc. Reviewed By: andywag Differential Revision: D61632621
zackycao
force-pushed
the
export-D61632621
branch
from
909e06b to
24243f4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61632621 |
zackycao
added a commit
to zackycao/torchx
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: meta-pytorch#947 Add appdef metadata to torchx event class. Scuba logs does not get modified yet. The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc. Reviewed By: andywag Differential Revision: D61632621
zackycao
force-pushed
the
export-D61632621
branch
from
24243f4 to
6ff55cb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61632621 |
zackycao
added a commit
to zackycao/torchx
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: meta-pytorch#947 Add appdef metadata to torchx event class. Scuba logs does not get modified yet. The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc. Reviewed By: andywag Differential Revision: D61632621
zackycao
force-pushed
the
export-D61632621
branch
from
6ff55cb to
fcc460b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61632621 |
zackycao
added a commit
to zackycao/torchx
that referenced
this pull request
Aug 23, 2024
Summary: Pull Request resolved: meta-pytorch#947 Add appdef metadata to torchx event class. Scuba logs does not get modified yet. The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc. Reviewed By: andywag Differential Revision: D61632621
zackycao
force-pushed
the
export-D61632621
branch
from
fcc460b to
0635374
Compare
zackycao
added a commit
to zackycao/torchx
that referenced
this pull request
Aug 23, 2024
Summary: Pull Request resolved: meta-pytorch#947 Add appdef metadata to torchx event class. Scuba logs does not get modified yet. The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc. Reviewed By: andywag Differential Revision: D61632621
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61632621 |
zackycao
force-pushed
the
export-D61632621
branch
from
0635374 to
f9fd26c
Compare
Summary: Pull Request resolved: meta-pytorch#947 Add appdef metadata to torchx event class. Scuba logs does not get modified yet. The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc. Reviewed By: andywag Differential Revision: D61632621
zackycao
force-pushed
the
export-D61632621
branch
from
f9fd26c to
2ff5db4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61632621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add appdef metadata to torchx event class. Scuba logs does not get modified yet.
Differential Revision: D61632621