Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password login on SSO instance drops the redirect URL #16216

Closed
camsaul opened this issue May 24, 2021 · 1 comment · Fixed by #16634
Closed

Password login on SSO instance drops the redirect URL #16216

camsaul opened this issue May 24, 2021 · 1 comment · Fixed by #16634
Assignees
@gusaiani
Labels
Administration/Auth/SSO Enterprise SSO like SAML and JWT Administration/Auth Google Auth, LDAP, pw+email login .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Milestone
0.40

Comments

@camsaul
Copy link
Member

camsaul commented May 24, 2021 •
edited

I think this is a regression, pretty sure it was working at some point.

To reproduce:

  1. Be logged out on stats
  2. Click link to https://<stats>/dashboard/223-engineering
  3. Login with email
  4. You're taken to the home page, rather than the dashboard
@camsaul camsaul added Type:Bug Product defects .Needs Triage labels May 24, 2021
@flamber flamber added Administration/Auth Google Auth, LDAP, pw+email login Administration/Auth/SSO Enterprise SSO like SAML and JWT .Frontend and removed .Needs Triage labels May 24, 2021
@flamber
Copy link
Contributor

flamber commented May 24, 2021

Related (or perhaps the same as) to #14781.
It's very important to click the "Sign in with email" in step 3, which changes the URL from /auth/login?redirect=%2Fdashboard%2F223-engineering to /auth/login/password (dropping the redirect parameter)
So this is only reproducible with SSO (excluding LDAP) enabled, but logging in through email+password.

@flamber flamber added the Priority:P3 Cosmetic bugs, minor bugs with a clear workaround label Jun 16, 2021
@flamber flamber changed the title Dashboard URL redirection broken on master (40-SNAPSHOT) Password login on SSO instance drops the redirect URL Jun 16, 2021
@flamber flamber mentioned this issue Jun 16, 2021
Closed
@gusaiani gusaiani self-assigned this Jun 16, 2021
@gusaiani gusaiani mentioned this issue Jun 16, 2021
Merged
@flamber flamber added this to the 0.40 milestone Jun 16, 2021
@flamber flamber mentioned this issue Jun 16, 2021
Closed
@deploysentinel deploysentinel bot mentioned this issue Apr 19, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Jul 26, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Dec 8, 2023
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Draft
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced May 8, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gusaiani gusaiani

Labels
Administration/Auth/SSO Enterprise SSO like SAML and JWT Administration/Auth Google Auth, LDAP, pw+email login .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Projects
None yet
Milestone
0.40
Development

Successfully merging a pull request may close this issue.

Pass along redirect URL search parameter in Google auth to email/password form metabase/metabase
3 participants
@gusaiani @flamber @camsaul