Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook: joins on multiple fields are removed if contain at least one incomplete condition #17710

Closed
kulyk opened this issue Sep 1, 2021 · 1 comment · Fixed by #17708
Closed
Assignees
Labels
Priority:P2 Average run of the mill bug Querying/Notebook Items specific to the Custom/Notebook query builder Type:Bug Product defects
Milestone

Comments

@kulyk
Copy link
Member

kulyk commented Sep 1, 2021

Describe the bug
Originally described in this comment from #17633. In notebook editor, if you have an incomplete join condition (e.g. you specified the left join field, but not the right one), once you click "Visualise" to run the query, the whole join gets removed. It worked that way earlier, but with joins on multiple fields it became much easier to face the problem.

To Reproduce

  1. Ask a question > Custom Question > Sample Dataset > Orders
  2. Join the Products table, you should see Metabase automatically suggests joining on PRODUCT_ID FK
  3. Click "Visualize", then open the notebook editor back (with an icon in the top right corner). You should see the join sections
  4. Click the "+" icon on the right side of the join section. Two cells with "Pick a column..." labels should appear. Don't touch them or select only one of them.
  5. Click "Visualize" again, open the notebook editor back. You can see the whole join section disappeared.

Expected behavior
The incomplete conditions should either stay on the UI, but not affect the query. Or only the incomplete conditions have to be removed.

Demo

before.mov

Information about your Metabase Installation:

Metabase v0.41.0-SNAPSHOT

@kulyk kulyk added Type:Bug Product defects Querying/Notebook Items specific to the Custom/Notebook query builder .Needs Triage labels Sep 1, 2021
@kulyk kulyk self-assigned this Sep 1, 2021
@flamber flamber added Priority:P2 Average run of the mill bug and removed .Needs Triage labels Sep 1, 2021
kulyk added a commit that referenced this issue Sep 1, 2021
@camsaul
Copy link
Member

camsaul commented Sep 16, 2021

@kulyk should this be added to the 0.41.0 milestone?

@flamber flamber added this to the 0.41 milestone Sep 23, 2021
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug Querying/Notebook Items specific to the Custom/Notebook query builder Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants