-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook: joins on multiple fields are removed if contain at least one incomplete condition #17710
Labels
Priority:P2
Average run of the mill bug
Querying/Notebook
Items specific to the Custom/Notebook query builder
Type:Bug
Product defects
Milestone
Comments
kulyk
added
Type:Bug
Product defects
Querying/Notebook
Items specific to the Custom/Notebook query builder
.Needs Triage
labels
Sep 1, 2021
@kulyk should this be added to the 0.41.0 milestone? |
This was referenced Aug 8, 2023
Merged
This was referenced Jan 11, 2024
This was referenced May 8, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority:P2
Average run of the mill bug
Querying/Notebook
Items specific to the Custom/Notebook query builder
Type:Bug
Product defects
Describe the bug
Originally described in this comment from #17633. In notebook editor, if you have an incomplete join condition (e.g. you specified the left join field, but not the right one), once you click "Visualise" to run the query, the whole join gets removed. It worked that way earlier, but with joins on multiple fields it became much easier to face the problem.
To Reproduce
PRODUCT_ID
FKExpected behavior
The incomplete conditions should either stay on the UI, but not affect the query. Or only the incomplete conditions have to be removed.
Demo
before.mov
Information about your Metabase Installation:
Metabase v0.41.0-SNAPSHOT
The text was updated successfully, but these errors were encountered: