Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot access Notebook for questions that uses a Custom Column as joining column #18818

Closed
flamber opened this issue Nov 2, 2021 · 0 comments · Fixed by #18845
Closed

Cannot access Notebook for questions that uses a Custom Column as joining column #18818

flamber opened this issue Nov 2, 2021 · 0 comments · Fixed by #18845
Assignees
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Notebook Items specific to the Custom/Notebook query builder .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented Nov 2, 2021

Describe the bug
Cannot access Notebook for questions that uses a Custom Column as joining column.
Trying to access the Notebook editor will cause a frontend reload, which is constantly sending /api/card/:id until browsing away.
Got a blank screen at some point too (think I tested on master).

Regression since 0.41.0

To Reproduce

  1. On 0.40.5: Custom question > Sample Dataset > Reviews
  2. Custom Column [Rating] as "CC just Rating"
  3. Join Orders on "CC just Rating"="Quantity"
  4. Summarize Count grouped by CreatedAt:Year
    image
  5. Save question, upgrade to 0.41.1, open the question (load results fine), but trying to access Notebook will cause the frontend to reload constantly.
    The browser console is drowning in various errors like:
Error thrown while validating clause i {fields: 'all', source-table: 11, condition: Array(3), alias: 'Orders', strategy: 'inner-join', …} TypeError: Cannot read properties of undefined (reading 'CC just Rating')
    at n.value (Dimension.js:1025)
    at StructuredQuery.js:1107
    at Array.map (<anonymous>)
    at StructuredQuery.js:1104
    at Array.map (<anonymous>)
    at n.value (StructuredQuery.js:1102)
    at n.value (StructuredQuery.js:1154)
    at i.value (Join.js:587)
    at n.value (StructuredQuery.js:462)
    at n.value (StructuredQuery.js:453)

TypeError: e.temporalUnit is not a function
    at JoinStep.jsx:550
    at qEe (JoinStep.jsx:566)
    at Qo (react-dom.production.min.js:153)
    at xs (react-dom.production.min.js:261)
    at vu (react-dom.production.min.js:246)
    at gu (react-dom.production.min.js:246)
    at uu (react-dom.production.min.js:239)
    at react-dom.production.min.js:123
    at t.unstable_runWithPriority (scheduler.production.min.js:19)
    at Vi (react-dom.production.min.js:122)

Information about your Metabase Installation:
Tested 0.39.5 thru 0.41.1 and commit 8f65be8 (latest 41.2 branch).

Additional context
Related to #18630

@flamber flamber added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Frontend Querying/Notebook Items specific to the Custom/Notebook query builder .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Nov 2, 2021
kulyk added a commit that referenced this issue Nov 4, 2021
@kulyk kulyk self-assigned this Nov 4, 2021
@flamber flamber added this to the 0.41.2 milestone Nov 4, 2021
kulyk added a commit that referenced this issue Nov 4, 2021
* Add repro for #18818

* Fix date time field check in JoinStep
@kulyk kulyk added the .Reproduced Issues reproduced in test (usually Cypress) label Nov 4, 2021
github-actions bot pushed a commit that referenced this issue Nov 4, 2021
* Add repro for #18818

* Fix date time field check in JoinStep
rlotun pushed a commit that referenced this issue Nov 4, 2021
* Add repro for #18818

* Fix date time field check in JoinStep
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Notebook Items specific to the Custom/Notebook query builder .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants