Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom expression autocomplete menu opens when focus is lost via keyboard #31643

Closed
kamilmielnik opened this issue Jun 16, 2023 · 0 comments · Fixed by #31994
Closed

Custom expression autocomplete menu opens when focus is lost via keyboard #31643

kamilmielnik opened this issue Jun 16, 2023 · 0 comments · Fixed by #31994
Assignees
@ranquild
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder Type:Bug Product defects
Milestone
0.47

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented Jun 16, 2023 •
edited

Describe the bug

Video
2023-06-16.17-49-04.mp4
Screenshot

image

To Reproduce

  1. Create a new question using Sample Database and Accounts table
  2. Click "Pick the metric you want to see"
  3. Click "Custom Expression"
  4. Type into the expression input Cou
  5. Accept the first hint for the Count function by hitting Enter
  6. Hit Tab

Expression input loses focus but autocomplete menu opens for it.

Expected behavior

Autocomplete menu closes and stays closed when expression input loses focus.

Severity

Low
@kamilmielnik kamilmielnik changed the title Custom expression autocomplete menu does not close when focus is moved with keyboard Custom expression autocomplete menu opens when focus is moved with keyboard Jun 16, 2023
@kamilmielnik kamilmielnik changed the title Custom expression autocomplete menu opens when focus is moved with keyboard Custom expression autocomplete menu opens when focus is lost via keyboard Jun 16, 2023
@paoliniluis paoliniluis added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder and removed .Needs Triage labels Jun 16, 2023
@ranquild ranquild self-assigned this Jun 29, 2023
@ranquild ranquild mentioned this issue Jun 29, 2023
Merged
@ranquild ranquild added this to the 0.47 milestone Aug 2, 2023
@deploysentinel deploysentinel bot mentioned this issue Dec 1, 2023
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
This was referenced May 8, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranquild ranquild

Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder Type:Bug Product defects
Projects
None yet
Milestone
0.47
Development

Successfully merging a pull request may close this issue.

Fix showing suggestions for an unfocused custom expression field metabase/metabase
3 participants
@paoliniluis @kamilmielnik @ranquild