-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLv2] Track drill-thru unit test coverage #36601
Conversation
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
@@ -107,6 +107,7 @@ | |||
(deftest ^:parallel table-view-available-drill-thrus-headers-pk-test | |||
(testing "column headers: click on" | |||
(testing "primary key - column filter (default: Is), sort, summarize (distinct only)" | |||
(lib.drill-thru.tu/coverage-available! 0 0 :header :pk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be better if we just made a wrapper around available-drill-thrus
that looked at the query shape and context shape and recorded this stuff, and then made sure lib.drill-thru.tu/test-available-drill-thrus
and other stuff in the drill thru test namespaces used it? Same for lib/drill-thru
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR approved if you want to check this in
It's not checked anywhere yet, but this is a first cut at some bookkeeping helpers we can use to ensure that all the (many!) permutations of drill-thrus are getting properly checked by the unit tests.
e333b70
to
e298c4a
Compare
|
I'm closing this PR, as the drill-thru test coverage has moved in a different direction. |
It's not checked anywhere yet, but this is a first cut at some
bookkeeping helpers we can use to ensure that all the (many!)
permutations of drill-thrus are getting properly checked by the unit
tests.