author page: moved logic from template to module #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
oalders
reviewed
Sep 27, 2016
Member
oalders
left a comment
oalders
left a comment
There was a problem hiding this comment.
Looks good. Thanks for doing this.
| took => $took, | ||
| total => $data->{hits}->{total}, | ||
| aggregated => $aggregated, | ||
| latest => $latest, |
| push @aggregated, $rel; | ||
| } | ||
|
|
||
| return +[ \@aggregated, $latest ]; |
Member
There was a problem hiding this comment.
What's the reason for the + here?
Contributor
Author
There was a problem hiding this comment.
ah, just style (got used to write +[] and +{} to indicate refs), nothing except readability
Member
There was a problem hiding this comment.
I can see it for
sub { +{ foo => 'bar' } }since that makes the braces easier to read, but with the array reference it mostly confuses me. :)
mickeyn
force-pushed
the
mickey/move_code_from_templates
branch
from
c502e9c to
965590c
Compare
Contributor
Author
|
@oalders updated code according to your comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another structure being built in the templates moved to the controller.