include metacpan user id in account profile #1857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I decided to create a copy of the metacpan icon in root/static/images/profile to keep consistent with all the other profile images. Closes metacpan#1199
|
Thanks @simbabque! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since metacpan is in itself also a profile that's identified by a user id I figured it makes sense to put this under Profiles. It could either go as the first or the last one. Since new additions always go to the bottom I figured it makes more sense to show it at the top.
I decided to create a copy of the metacpan icon in root/static/images/profile to keep consistent with all the other profile images.
Not sure if perlmodules.net is actually using the user id already, but if they are (and possibly others also do) it might make sense to include an FAQ entry that explains what the user id can be used for and where to find it.
Closes #1199