use forwarded headers #2005
Merged
use forwarded headers #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use X-Forwarded-For etc headers to override standard headers. Existing Plack middleware don't quite cover the use case we have. ReverseProxy will only take the nearest link from X-Forwarded-For, which for us will be the Fastly servers. Fastly is configured to override any incoming X-Forwarded-For header, so we can safely use the farthest link, which will be the end user. Other middleware don't support the other headers we would like to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use X-Forwarded-For etc headers to override standard headers. Existing
Plack middleware don't quite cover the use case we have. ReverseProxy
will only take the nearest link from X-Forwarded-For, which for us will
be the Fastly servers. Fastly is configured to override any incoming
X-Forwarded-For header, so we can safely use the farthest link, which
will be the end user.
Other middleware don't support the other headers we would like to use.