[libc++] Refactor clang-query checks to clang-tidy checks to get less obscure error messages

Also remove clang-query related code, since it's unused now.

Reviewed By: ldionne, Mordante, #libc

Spies: libcxx-commits, arichardson

Differential Revision: https://reviews.llvm.org/D141805

Author: philnik777

libcxx/docs/TestingLibcxx.rst

@@ -98,8 +98,7 @@ Additional tools
 The libc++ test suite uses a few optional tools to improve the code quality.
 
 These tools are:
-- clang-query
-- clang-tidy
+- clang-tidy (you might need additional dev packages to compile libc++-specific clang-tidy checks)
 
 Writing Tests
 -------------

libcxx/include/__memory_resource/unsynchronized_pool_resource.h

@@ -85,7 +85,7 @@ class _LIBCPP_TYPE_VIS unsynchronized_pool_resource : public memory_resource {
 
   void do_deallocate(void* __p, size_t __bytes, size_t __align) override;
 
-  _LIBCPP_HIDE_FROM_ABI bool do_is_equal(const memory_resource& __other) const _NOEXCEPT override {
+  _LIBCPP_HIDE_FROM_ABI_VIRTUAL bool do_is_equal(const memory_resource& __other) const _NOEXCEPT override {
     return &__other == this;
   }
 

libcxx/test/libcxx/clang_query.sh.cpp

@@ -6,11 +6,13 @@ set(CMAKE_FIND_PACKAGE_SORT_DIRECTION DEC)
 find_package(Clang 16)
 
 set(SOURCES
+    abi_tag_on_virtual.cpp
+    hide_from_abi.cpp
     robust_against_adl.cpp
-    libcpp_module.cpp
     qualify_declval.cpp
-   )
 
+    libcpp_module.cpp
+   )
 
 if(NOT Clang_FOUND)
   message(STATUS "Could not find a suitable version of the Clang development package;