Skip to content

Commit 80c7e93

Browse files
committed
[libc++] Add a bunch of missing _LIBCPP_HIDE_FROM_ABI
Reviewed By: ldionne, Mordante, var-const, huixie90, #libc Spies: jloser, libcxx-commits, arichardson, miyuki Differential Revision: https://reviews.llvm.org/D129968
1 parent f159695 commit 80c7e93

File tree

94 files changed

+668
-319
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+668
-319
lines changed

libcxx/docs/TestingLibcxx.rst

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,15 @@ configuration easier.
9292
$ make -C <build> cxx-test-depends
9393
$ <build>/bin/llvm-lit -sv libcxx/test # will use your custom config file
9494
95+
Additional tools
96+
----------------
97+
98+
The libc++ test suite uses a few optional tools to improve the code quality.
99+
100+
These tools are:
101+
- clang-query
102+
- clang-tidy
103+
95104
Writing Tests
96105
-------------
97106

libcxx/include/__algorithm/find_end.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ template <
9191
class _Sent2,
9292
class _Proj1,
9393
class _Proj2>
94-
_LIBCPP_CONSTEXPR_AFTER_CXX17 _Iter1 __find_end(
94+
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17 _Iter1 __find_end(
9595
_Iter1 __first1,
9696
_Sent1 __sent1,
9797
_Iter2 __first2,
@@ -144,7 +144,7 @@ template <
144144
class _Sent2,
145145
class _Proj1,
146146
class _Proj2>
147-
_LIBCPP_CONSTEXPR_AFTER_CXX11 _Iter1 __find_end(
147+
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11 _Iter1 __find_end(
148148
_Iter1 __first1,
149149
_Sent1 __sent1,
150150
_Iter2 __first2,

libcxx/include/__algorithm/find_first_of.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
_LIBCPP_BEGIN_NAMESPACE_STD
2222

2323
template <class _ForwardIterator1, class _ForwardIterator2, class _BinaryPredicate>
24+
_LIBCPP_HIDE_FROM_ABI
2425
_LIBCPP_CONSTEXPR_AFTER_CXX11 _ForwardIterator1 __find_first_of_ce(_ForwardIterator1 __first1,
2526
_ForwardIterator1 __last1,
2627
_ForwardIterator2 __first2,

libcxx/include/__algorithm/inplace_merge.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ class __invert // invert the sense of a comparison
5656

5757
template <class _AlgPolicy, class _Compare, class _InputIterator1, class _Sent1,
5858
class _InputIterator2, class _Sent2, class _OutputIterator>
59+
_LIBCPP_HIDE_FROM_ABI
5960
void __half_inplace_merge(_InputIterator1 __first1, _Sent1 __last1,
6061
_InputIterator2 __first2, _Sent2 __last2,
6162
_OutputIterator __result, _Compare&& __comp)
@@ -83,6 +84,7 @@ void __half_inplace_merge(_InputIterator1 __first1, _Sent1 __last1,
8384
}
8485

8586
template <class _AlgPolicy, class _Compare, class _BidirectionalIterator>
87+
_LIBCPP_HIDE_FROM_ABI
8688
void __buffered_inplace_merge(
8789
_BidirectionalIterator __first,
8890
_BidirectionalIterator __middle,

libcxx/include/__algorithm/is_partitioned.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
_LIBCPP_BEGIN_NAMESPACE_STD
1919

2020
template <class _InputIterator, class _Predicate>
21-
_LIBCPP_NODISCARD_EXT _LIBCPP_CONSTEXPR_AFTER_CXX17 bool
21+
_LIBCPP_NODISCARD_EXT _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17 bool
2222
is_partitioned(_InputIterator __first, _InputIterator __last, _Predicate __pred)
2323
{
2424
for (; __first != __last; ++__first)

libcxx/include/__algorithm/lexicographical_compare.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
_LIBCPP_BEGIN_NAMESPACE_STD
2222

2323
template <class _Compare, class _InputIterator1, class _InputIterator2>
24-
_LIBCPP_CONSTEXPR_AFTER_CXX17 bool
24+
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17 bool
2525
__lexicographical_compare(_InputIterator1 __first1, _InputIterator1 __last1,
2626
_InputIterator2 __first2, _InputIterator2 __last2, _Compare __comp)
2727
{

libcxx/include/__algorithm/merge.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
_LIBCPP_BEGIN_NAMESPACE_STD
2323

2424
template <class _Compare, class _InputIterator1, class _InputIterator2, class _OutputIterator>
25-
_LIBCPP_CONSTEXPR_AFTER_CXX17
25+
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17
2626
_OutputIterator
2727
__merge(_InputIterator1 __first1, _InputIterator1 __last1,
2828
_InputIterator2 __first2, _InputIterator2 __last2, _OutputIterator __result, _Compare __comp)

libcxx/include/__algorithm/minmax_element.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ pair<_Iter, _Iter> __minmax_element_impl(_Iter __first, _Sent __last, _Comp& __c
7979
}
8080

8181
template <class _ForwardIterator, class _Compare>
82-
_LIBCPP_NODISCARD_EXT _LIBCPP_CONSTEXPR_AFTER_CXX11
82+
_LIBCPP_NODISCARD_EXT _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11
8383
pair<_ForwardIterator, _ForwardIterator>
8484
minmax_element(_ForwardIterator __first, _ForwardIterator __last, _Compare __comp) {
8585
static_assert(__is_cpp17_forward_iterator<_ForwardIterator>::value,

libcxx/include/__algorithm/next_permutation.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
_LIBCPP_BEGIN_NAMESPACE_STD
2626

2727
template <class _AlgPolicy, class _Compare, class _BidirectionalIterator, class _Sentinel>
28-
_LIBCPP_CONSTEXPR_AFTER_CXX17
29-
pair<_BidirectionalIterator, bool>
28+
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17 pair<_BidirectionalIterator, bool>
3029
__next_permutation(_BidirectionalIterator __first, _Sentinel __last, _Compare&& __comp)
3130
{
3231
using _Result = pair<_BidirectionalIterator, bool>;

libcxx/include/__algorithm/nth_element.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
_LIBCPP_BEGIN_NAMESPACE_STD
2727

2828
template<class _Compare, class _RandomAccessIterator>
29-
_LIBCPP_CONSTEXPR_AFTER_CXX11 bool
29+
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11 bool
3030
__nth_element_find_guard(_RandomAccessIterator& __i, _RandomAccessIterator& __j,
3131
_RandomAccessIterator __m, _Compare __comp)
3232
{
@@ -42,7 +42,7 @@ __nth_element_find_guard(_RandomAccessIterator& __i, _RandomAccessIterator& __j,
4242
}
4343

4444
template <class _AlgPolicy, class _Compare, class _RandomAccessIterator>
45-
_LIBCPP_CONSTEXPR_AFTER_CXX11 void
45+
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11 void
4646
__nth_element(_RandomAccessIterator __first, _RandomAccessIterator __nth, _RandomAccessIterator __last, _Compare __comp)
4747
{
4848
using _Ops = _IterOps<_AlgPolicy>;

0 commit comments

Comments
 (0)