Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document changes: provide the validStatus and saveStatus only when changed #378

Closed
teosarca opened this issue May 16, 2017 · 2 comments
Closed

Document changes: provide the validStatus and saveStatus only when changed #378

teosarca opened this issue May 16, 2017 · 2 comments
Assignees
@teosarca @metas-lc
Labels
branch:master branch:release priority:high type:bug
Milestone
2017-20

Comments

@teosarca
Copy link
Member

teosarca commented May 16, 2017 •
edited by metas-ts
Loading

Is this a bug or feature request?

Bug

What is the current behavior?

The validStatus and saveStatus are provided almost all the time.
In some cases, because of that, the document changes list that is provided back to frontend is huge and the frontend on it's turn freeze chrome for a while (i.e. you are not able to close the browser tab).

Which are the steps to reproduce?

Try editing a role, e.g. https://w101.metasfresh.com:8443/window/111/1000055.
Try changing the name, or try activating/deactivating a window access or a task access or something.
Your browser tab will freeze.
Wait a (long) while and the chrome tab will work again.
If you inspect the response of the endpoint which was called to change the document, you will see that it has a huge amount of changes, almost all of them are only about valid status and save status.

What is the expected or desired behavior?

Backend shall keep the response as small as possible.
It shall send only the valid and save statuses which really changed.

NOTE: might be that we also have to rethink when and how the valid and save status are changed.
@teosarca teosarca added this to the 2017-20 milestone May 16, 2017
@teosarca teosarca mentioned this issue May 16, 2017
Closed
teosarca added a commit that referenced this issue May 16, 2017
@teosarca
introduce IDocumentChangesCollector parameter to methods which are co…
ed8520d 
…municating the state changes (partial)

we shall do that instead of using
Execution.getCurrentDocumentChangesCollector[OrNull]().
In this way we might be able to control what updates will be sent. In
some cases we will be able to not collect them at all.

#378
teosarca added a commit that referenced this issue May 20, 2017
@teosarca
MASIVE included documents and refactoring
d6225dd 
highlight:
* introduced HighVolumeReadWriteIncludedDocumentsCollection
* deprecated IncludedDocumentsCollection

#378
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 20, 2017
@teosarca
Fix AD_Tab.AD_Column_ID not matching AD_Tab.AD_Table_ID
71bbff2 
metasfresh/metasfresh-webui-api-legacy#378
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 20, 2017
@teosarca
add PK to AD_Role_Included and AD_Role_OrgAccess
60f7254 
metasfresh/metasfresh-webui-api-legacy#378
teosarca added a commit that referenced this issue May 20, 2017
@teosarca
cleanup
86d42d6 
#378
teosarca added a commit that referenced this issue May 21, 2017
@teosarca
JSONOptions: acquire permissions only if is really needed
db94eeb 
#378
@teosarca teosarca self-assigned this May 21, 2017
@teosarca teosarca mentioned this issue May 21, 2017
Merged
teosarca added a commit that referenced this issue May 21, 2017
@teosarca
Merge pull request #403 from metasfresh/gh378webui
58058c6 
Document changes: provide the validStatus and saveStatus only when changed #378
@teosarca teosarca mentioned this issue May 21, 2017
Closed
@metas-lc
Copy link

Found this while testing another task:

  • create a new purchase order
  • add an empty line - no product (with add new)
    => line should be pink but it's not NOK
  • refresh the page
    => the line was deleted and the document is not saved (reason:"child invalid") NOK

teosarca added a commit that referenced this issue May 22, 2017
@teosarca
bugfix HighVolumeReadWriteIncludedDocumentsCollection.getDocuments()
954203c 
#378 (comment)
teosarca added a commit that referenced this issue May 22, 2017
@teosarca
DocumentChanges.collectFrom(Document) shall also collect save/valid s…
925bb0f 
…tatus

#378 (comment)
teosarca added a commit that referenced this issue May 22, 2017
@teosarca
when creating an included document, collect the whole document
50be1f4 
#378 (comment)
@metas-lc metas-lc self-assigned this May 22, 2017
@metas-lc
Copy link

IT
retested testcase above => adding an empty line makes it pink and refreshing the page doesn't make it disappear OK
the rest tested on #365

  • small problem with editing included tabs when the header is inactive. Rest is fine.

metas-ts added a commit to metasfresh/metasfresh that referenced this issue May 25, 2017
@metas-ts
complement ReleaseNotes.md
eae53b0 
[#409](metasfresh/metasfresh-webui-api-legacy#409) backend: change view attributes endpoint location
[#1639](#1635) cannot complete distribution order
[#760](metasfresh/metasfresh-webui-frontend-legacy#760) Fix the texts displayed while loading
[#787](metasfresh/metasfresh-webui-frontend-legacy#787) window endpoint: change "attribute" to "field"
 [#763](metasfresh/metasfresh-webui-frontend-legacy#763) grid: right click on a cell and zoom into
 * [#1617](#1617) Check if imported esr file is v11 file
* [#1615](#1615) Address lines is cut off on shipment jasper document
* [#1591](#1591) Password Field is missing in user window in WebUI
* [#1586](#1586) New Window for OrgType in WebUI
* [#1584](#1584) New Window for Org in WebUI
* [#1585](#1585) New Window Client in WebUI
* [#762](metasfresh/metasfresh-webui-frontend-legacy#762) Empty Filter vs. Default Value in Window Filtering
* [#778](metasfresh/metasfresh-webui-frontend-legacy#778) Yellow pulse effect w/o data change
* [#407](metasfresh/metasfresh-webui-api-legacy#407) View filtering by virtual SQL column not working
* [#412](metasfresh/metasfresh-webui-api-legacy#412) Provide API for sorting included tab
* [#411](metasfresh/metasfresh-webui-api-legacy#411) Provide "size" to layout element
* [#396](metasfresh/metasfresh-webui-api-legacy#396) Vendor Return Actions in WebUI
* [#772](metasfresh/metasfresh-webui-frontend-legacy#772) automatic Column sizing not showing all text although space would be available
* [#774](metasfresh/metasfresh-webui-frontend-legacy#774) Fix invalid "GET /window/{windowId}/{tabId} call
* [#764](metasfresh/metasfresh-webui-frontend-legacy#764) Long text boxes shall have a border around
* [#769](metasfresh/metasfresh-webui-frontend-legacy#769) Honor tab stale flag also when editing in advanced mode
* [#767](metasfresh/metasfresh-webui-frontend-legacy#767) Got same notification several times
^* [#766](metasfresh/metasfresh-webui-frontend-legacy#766) issue panel doesn't open
* [#765](metasfresh/metasfresh-webui-frontend-legacy#765) Date + Time Info in Notification window
[#378](metasfresh/metasfresh-webui-api-legacy#378) Document changes: provide the validStatus and saveStatus only when changed
* [#405](metasfresh/metasfresh-webui-api-legacy#405) Backend shall provide JSON document fields indexed by field's name
* [#1560](#1560) Add description fields to invoice window
* [#1577](#1577) Introduce /test/ping/notifications server troubleshooting endpoint

me-45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teosarca teosarca

@metas-lc metas-lc

Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
2017-20
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-lc