Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Fix the texts displayed while loading #760

Closed
teosarca opened this issue May 18, 2017 · 6 comments
Closed

Fix the texts displayed while loading #760

teosarca opened this issue May 18, 2017 · 6 comments

Comments

@teosarca
Copy link
Member

teosarca commented May 18, 2017

Steps to reproduce / Expected behavior

1. Menu actions:

  • click on menu
  • frontend shows "There is no action" until the actions are loaded

Expectation: it shall show a loading indicator/text or nothing, but NOT "There is no action" because induces FUD

image

2. Window / single document

  • go to sales orders for example
  • click on a sales order
  • while loading the "status indicator line" is red => NOK
  • sometimes, until it's loaded, the "404 not found" text is shown => NOK

Expectation: while loading the document

  • the "status indicator line" shall not be red.
  • the "404 not found" text shall never be shown because it's not right and induces FUD

image

@teosarca teosarca added this to the 2017-21 milestone May 18, 2017
@cadavre
Copy link
Contributor

cadavre commented May 18, 2017

BTW "There ARE no actions" ;)

@teosarca
Copy link
Member Author

Here is the 404 issue, but to be honest i don't know how to reproduce. Might be when we have slow response time from backend....

image

damianprzygodzki added a commit that referenced this issue May 23, 2017
#760 Actions init state modified, condition for notSavedDoc fixed
@damianprzygodzki damianprzygodzki self-assigned this May 23, 2017
@teosarca
Copy link
Member Author

Quick tested by opening the Menu while in dashboard: stays like this forever:
image

@metas-lc
Copy link

IT

  1. go to a place where are a lt of actions. E.g. Material receipt candidates, open one and select the 3 dots
    => actions are loaded really fast, but you can slightly see that there's a gear before they appear
    OK
  2. opened multiple windows that contains lots of entries, like order,receipt candidates ,invoice candidates
  • selected documents, used back from grid view to document
    => 404 not found is not appearing OK
  1. press the 3 dots while you are in dashboard
    => Actions - There is no actions appears instantly OK

@teosarca
Copy link
Member Author

Tested:

  • open sales order
  • go to batch entry and write some product name which does not exist, e.g. zzzzzzzzz
    => the gear/loading icon is shown even if the typehead was performed and there were no results => NOK => it shall show the "no results" text.

image

@metas-lc
Copy link

IT
repeated steps 1-3 from IT1 => works the same OK

  1. open sales order
  2. go to batch entry and write some product name which does not exist, e.g. zzzzzzzzz
    => "no results" text (the gear appears just a bit)
    => works the same if you use add new instead of batch entry

metas-ts added a commit to metasfresh/metasfresh that referenced this issue May 25, 2017
[#409](metasfresh/metasfresh-webui-api-legacy#409) backend: change view attributes endpoint location
[#1639](#1635) cannot complete distribution order
[#760](metasfresh/metasfresh-webui-frontend-legacy#760) Fix the texts displayed while loading
[#787](metasfresh/metasfresh-webui-frontend-legacy#787) window endpoint: change "attribute" to "field"
 [#763](metasfresh/metasfresh-webui-frontend-legacy#763) grid: right click on a cell and zoom into
 * [#1617](#1617) Check if imported esr file is v11 file
* [#1615](#1615) Address lines is cut off on shipment jasper document
* [#1591](#1591) Password Field is missing in user window in WebUI
* [#1586](#1586) New Window for OrgType in WebUI
* [#1584](#1584) New Window for Org in WebUI
* [#1585](#1585) New Window Client in WebUI
* [#762](metasfresh/metasfresh-webui-frontend-legacy#762) Empty Filter vs. Default Value in Window Filtering
* [#778](metasfresh/metasfresh-webui-frontend-legacy#778) Yellow pulse effect w/o data change
* [#407](metasfresh/metasfresh-webui-api-legacy#407) View filtering by virtual SQL column not working
* [#412](metasfresh/metasfresh-webui-api-legacy#412) Provide API for sorting included tab
* [#411](metasfresh/metasfresh-webui-api-legacy#411) Provide "size" to layout element
* [#396](metasfresh/metasfresh-webui-api-legacy#396) Vendor Return Actions in WebUI
* [#772](metasfresh/metasfresh-webui-frontend-legacy#772) automatic Column sizing not showing all text although space would be available
* [#774](metasfresh/metasfresh-webui-frontend-legacy#774) Fix invalid "GET /window/{windowId}/{tabId} call
* [#764](metasfresh/metasfresh-webui-frontend-legacy#764) Long text boxes shall have a border around
* [#769](metasfresh/metasfresh-webui-frontend-legacy#769) Honor tab stale flag also when editing in advanced mode
* [#767](metasfresh/metasfresh-webui-frontend-legacy#767) Got same notification several times
^* [#766](metasfresh/metasfresh-webui-frontend-legacy#766) issue panel doesn't open
* [#765](metasfresh/metasfresh-webui-frontend-legacy#765) Date + Time Info in Notification window
[#378](metasfresh/metasfresh-webui-api-legacy#378) Document changes: provide the validStatus and saveStatus only when changed
* [#405](metasfresh/metasfresh-webui-api-legacy#405) Backend shall provide JSON document fields indexed by field's name
* [#1560](#1560) Add description fields to invoice window
* [#1577](#1577) Introduce /test/ping/notifications server troubleshooting endpoint

me-45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants