Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Got same notification several times #767

Closed
teosarca opened this issue May 19, 2017 · 3 comments
Closed

Got same notification several times #767

teosarca opened this issue May 19, 2017 · 3 comments
Assignees
@damianprzygodzki @metas-lc
Labels
branch:master branch:release priority:high type:bug
Milestone
2017-21

Comments

@teosarca
Copy link
Member

teosarca commented May 19, 2017 •
edited
Loading

Type of issue

Bug

Current behavior / Steps to reproduce

  • you need to freshly login, so if u are already logged it pls logout and login. Pls do logout/login several times!

  • on another tab please open: http://w101.metasfresh.com:8081/websocket_test.html
    ** connect to topic: /notifications/.
    *** if you logged in with SuperUser, the topic shall be /notifications/100
    *** if you logged in with "it", the topic shall be /notifications/2188223

  • on another tab please call: http://w101.metasfresh.com:8181/test/ping/notifications => that call will create a notification on metasfresh server which will be forwarded to metasfresh-webui-server which will forward it to frontend (view websockets)
    ** you will need to authenticate with SuperUser and it's password

Result:

  • frontend displays the notification 2 or 3 times
  • websocket_test.html : got the notification only once => webui server is sending it once

Now, if you would refresh the frontend page you will see that each notification is displayed once.

So, i suspect the issue is on frontend when it gets the notifications via websocket. Might be that frontend (for some reason) have the multiple websocket listeners for same /notifications/userId endpoint and that's why the notifications are added several times?

image

image
@teosarca teosarca added this to the 2017-21 milestone May 19, 2017
@teosarca
Copy link
Member Author

update: check again. you need to logout and login several times (without doing browser refresh).
Each time would grow the number of notifications "received" from websocket.

@cadavre
Copy link
Contributor

cadavre commented May 19, 2017

Might it be we're not disconnecting socket on logout?

@damianprzygodzki damianprzygodzki self-assigned this May 22, 2017
damianprzygodzki added a commit that referenced this issue May 22, 2017
@damianprzygodzki
#767 Notification SockJS client enclosured to service
62e2cb2
damianprzygodzki added a commit that referenced this issue May 22, 2017
@damianprzygodzki
Merge pull request #775 from metasfresh/dev-767
ed0c7a6 
#767 Notification SockJS client enclosured to service
@metas-lc metas-lc self-assigned this May 22, 2017
@metas-lc
Copy link

IT

  • used test notifications and also normal ones from creating receipts
    => each notification appeared once OK
  • logout-login several times
    => each notification appeared once OK

metas-ts added a commit to metasfresh/metasfresh that referenced this issue May 25, 2017
@metas-ts
complement ReleaseNotes.md
eae53b0 
[#409](metasfresh/metasfresh-webui-api-legacy#409) backend: change view attributes endpoint location
[#1639](#1635) cannot complete distribution order
[#760](metasfresh/metasfresh-webui-frontend-legacy#760) Fix the texts displayed while loading
[#787](metasfresh/metasfresh-webui-frontend-legacy#787) window endpoint: change "attribute" to "field"
 [#763](metasfresh/metasfresh-webui-frontend-legacy#763) grid: right click on a cell and zoom into
 * [#1617](#1617) Check if imported esr file is v11 file
* [#1615](#1615) Address lines is cut off on shipment jasper document
* [#1591](#1591) Password Field is missing in user window in WebUI
* [#1586](#1586) New Window for OrgType in WebUI
* [#1584](#1584) New Window for Org in WebUI
* [#1585](#1585) New Window Client in WebUI
* [#762](metasfresh/metasfresh-webui-frontend-legacy#762) Empty Filter vs. Default Value in Window Filtering
* [#778](metasfresh/metasfresh-webui-frontend-legacy#778) Yellow pulse effect w/o data change
* [#407](metasfresh/metasfresh-webui-api-legacy#407) View filtering by virtual SQL column not working
* [#412](metasfresh/metasfresh-webui-api-legacy#412) Provide API for sorting included tab
* [#411](metasfresh/metasfresh-webui-api-legacy#411) Provide "size" to layout element
* [#396](metasfresh/metasfresh-webui-api-legacy#396) Vendor Return Actions in WebUI
* [#772](metasfresh/metasfresh-webui-frontend-legacy#772) automatic Column sizing not showing all text although space would be available
* [#774](metasfresh/metasfresh-webui-frontend-legacy#774) Fix invalid "GET /window/{windowId}/{tabId} call
* [#764](metasfresh/metasfresh-webui-frontend-legacy#764) Long text boxes shall have a border around
* [#769](metasfresh/metasfresh-webui-frontend-legacy#769) Honor tab stale flag also when editing in advanced mode
* [#767](metasfresh/metasfresh-webui-frontend-legacy#767) Got same notification several times
^* [#766](metasfresh/metasfresh-webui-frontend-legacy#766) issue panel doesn't open
* [#765](metasfresh/metasfresh-webui-frontend-legacy#765) Date + Time Info in Notification window
[#378](metasfresh/metasfresh-webui-api-legacy#378) Document changes: provide the validStatus and saveStatus only when changed
* [#405](metasfresh/metasfresh-webui-api-legacy#405) Backend shall provide JSON document fields indexed by field's name
* [#1560](#1560) Add description fields to invoice window
* [#1577](#1577) Introduce /test/ping/notifications server troubleshooting endpoint

me-45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@damianprzygodzki damianprzygodzki

@metas-lc metas-lc

Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
2017-21
Development

No branches or pull requests
5 participants
@cadavre @teosarca @metas-ts @damianprzygodzki @metas-lc