Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

KPI: implement a non intrusive way to display KPI related errors #537

Closed
teosarca opened this issue Mar 14, 2017 · 6 comments
Closed

KPI: implement a non intrusive way to display KPI related errors #537

teosarca opened this issue Mar 14, 2017 · 6 comments

Comments

@teosarca
Copy link
Member

Current behavior

Case:

  • elasticsearch server is down
  • frontend is calling /data endpoint for each KPI each 10sec (by default)
  • so from 10 to 10sec we get the error popup
    That's totally annoying and the user can do nothing about it.

Expected behavior

Find an non-intrusive way to flag those KPIs (draggable widgets) where an error occurred while fetching the data.
idea: Might be the title bar colored in pale red with some exclamation mark icon near it. When hovering on that exclamation mark the error text shall be displayed.
But if the designer has a better idea, we shall go with that.

image

@cadavre
Copy link
Contributor

cadavre commented Mar 22, 2017

Part of #253 .

I would remove error notifications and add widget placeholder with some grayed-out "chart" icon and grayed-out text like "Error loading data".

@teosarca
Copy link
Member Author

hi @cadavre ,
sounds good for me...
but i would also show the error message when hovering on it because else there is no way to find out why that KPI failed...

@cadavre
Copy link
Contributor

cadavre commented Mar 23, 2017

I think we should go with what I described in #253 (comment) .

If you had this dev mode we could always display notifications with click possibility (to display popup with detailed info). User doesn't need to read full error description as it doesn't change his life at all – once after all he/she cannot see widget. :)

@teosarca
Copy link
Member Author

If you had this dev mode we could always display notifications with click possibility (to display popup with detailed info). User doesn't need to read full error description as it doesn't change his life at all – once after all he/she cannot see widget. :)

Yes, but behind the "user" it's us all... 1st level support, 2nd level support, 3rd level support etc.
That's the reason why i don't feel the "dev" mode is the way.

On the other hand, i can say it again, i agree with you about the need of #253 .... we just have to gradually get to it :)

@cadavre
Copy link
Contributor

cadavre commented Mar 24, 2017

@teosarca understood. I think we should use UI error elements to print only human-readable and pretty errors. That's why notification with only generic error is cool, lookup with user-friendly error texts are cool, inputs with validation errors are cool.

I just talked to @Dunkat and suggested to log all errors (that are regularly shown in notifications) to console. This way you (dev) will have always full error info and you'll be able to use apps like https://newrelic.com/browser-monitoring/features in the future.

Dunkat added a commit that referenced this issue Mar 24, 2017
Dunkat added a commit that referenced this issue Mar 24, 2017
damianprzygodzki added a commit that referenced this issue Mar 24, 2017
KPI: implement a non intrusive way to display KPI related errors #537
@teosarca
Copy link
Member Author

tested locally, works!

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 28, 2017
[#1382](#1382) Make Packing Item editable in Manufacturing Order Header
[#323](metasfresh/metasfresh-webui-api-legacy#323) Manufacturing Issue/Receipt: receipt lines shall be displayed first
[#689](metasfresh/metasfresh-webui-frontend-legacy#689) Image widget is missing right border
[#326](metasfresh/metasfresh-webui-api-legacy#326) technical: Remove JSONProcessInstanceResult deprecated properties
[#680](metasfresh/metasfresh-webui-frontend-legacy#680) Navigation breadcrumb vs. Navigation Menu
[#329](metasfresh/metasfresh-webui-api-legacy#329) Issue HU 404 not found#
[#688](metasfresh/metasfresh-webui-frontend-legacy#688) Main page /dashboard is broken
[#667](metasfresh/metasfresh-webui-frontend-legacy#667) Change /rest/api/pattribute request message
[#319](metasfresh/metasfresh-webui-api-legacy#319) Manufacturing Issue/Receipt: show BOM line attributes if any
[#317](metasfresh/metasfresh-webui-api-legacy#317) Manufacturing Issue/Receipt: drop StatusInfo column
[#248](metasfresh/metasfresh-webui-frontend-legacy#248) Handle Password Fields in WebUI
[#678](metasfresh/metasfresh-webui-frontend-legacy#678) Get rid of deprecated static docNo input in header.
[#151](metasfresh/metasfresh-webui-api-legacy#151) grid view websocket notifications: fullyChanged shall not be set when changedIds is set
[#664](metasfresh/metasfresh-webui-frontend-legacy#664) process doesn't open directly
[#311](metasfresh/metasfresh-webui-api-legacy#311) Switching language does not translate document lookup values
[#310](metasfresh/metasfresh-webui-api-legacy#310) Switching language does not translate document references
[#306](metasfresh/metasfresh-webui-api-legacy#306) Address missing in 'Adresse' for bpartner created on-the-fly
[#673](metasfresh/metasfresh-webui-frontend-legacy#673) Wrong report file endpoint is called for processes which are started from main menu
[#1347](#1347) technical: ModelClassGenerator shall generate BigDecimal.ZERO instead of Env.ZERO
[#880](#880) Improve IProcessPrecondition framework
[#641](metasfresh/metasfresh-webui-frontend-legacy#641) Shortcuts behavior sometimes weird
[#644](metasfresh/metasfresh-webui-frontend-legacy#644) Creating a new Discount record error
[#649](metasfresh/metasfresh-webui-frontend-legacy#649) windowId shall be handled as a string and not as a number
[#596](metasfresh/metasfresh-webui-frontend-legacy#596) red line appears on document only after refresh
[#433](metasfresh/metasfresh-webui-frontend-legacy#433) ShipmentSchedule: Only displayed after "No data" showing up
[#270](metasfresh/metasfresh-webui-api-legacy#270) cannot add trading unit with batch entry after using add new
[#537](metasfresh/metasfresh-webui-frontend-legacy#537) KPI: implement a non intrusive way to display KPI related errors
[#268](metasfresh/metasfresh-webui-api-legacy#268) HU attributes shall always provide the WidgetType along with the data/changes
[#579](metasfresh/metasfresh-webui-frontend-legacy#579) DocumentNo field is not updated

me-45
hairy tinkerbell struck again
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants