Skip to content

Enable loading of .vue files from npm packages #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Enable loading of .vue files from npm packages #214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a720e8
enable loading of .vue files from npm packages
Jun 30, 2017
8730baa
fix ES module detection
Jun 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/vue-component/plugin/vue-compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,22 @@ VueComponentCompiler = class VueCompo extends CachingCompiler {

const { js, templateHash } = generateJs(vueId, inputFile, compileResult)

let outputFilePath = inputFile.getPathInPackage();
// Meteor will error when loading .vue files on the server unless they are postfixed with .js
if (inputFile.getArch().indexOf('os') === 0 && inputFilePath.indexOf('node_modules') !== -1) {
outputFilePath += '.js';
}

// Including the source maps for .vue files from node_modules breaks source mapping.
const sourceMap = inputFilePath.indexOf('node_modules') === -1
? compileResult.map
: undefined;

// Add JS Source file
inputFile.addJavaScript({
path: inputFile.getPathInPackage(),
path: outputFilePath,
data: js,
sourceMap: compileResult.map,
sourceMap: sourceMap,
lazy: false,
});

Expand Down Expand Up @@ -610,7 +621,7 @@ function generateJs (vueId, inputFile, compileResult, isHotReload = false) {
js += `__vue_options__.packageName = '${inputFile.getPackageName()}';`;

// Export
js += `module.export('default', exports.default = __vue_script__);`;
js += `module.export('default', exports.default = __vue_script__);exports.__esModule = true;`;

if (!isHotReload) {
// Hot-reloading
Expand Down