Skip to content

fix: vue-component-dev-client in IE #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2019
Merged

fix: vue-component-dev-client in IE #359

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52c3904
I bet I know how this happened
GeoffreyBooth Apr 17, 2019
46c39e3
Use the transpiled version of socket.io client, so that it's compatib…
GeoffreyBooth Apr 17, 2019
1c17cf8
Bump version
GeoffreyBooth Apr 17, 2019
a343e55
Revert "Bump version"
GeoffreyBooth Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vue-component-dev-client/client/dev-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ Meteor.startup(function () {

console.log('%cHMR%c Dev server URL: %c' + devUrl, tagStyle, '', 'font-weight: bold;')

console.log(`%cIf you have issues connecting to the dev server, set the 'HMR_URL' env letiable to the URL of the dev server displayed in the meteor console.`, infoStyle)
console.log(`%cIf you have issues connecting to the dev server, set the 'HMR_URL' env variable to the URL of the dev server displayed in the meteor console.`, infoStyle)

// NOTE: Socket lib don't allow mix HTTP and HTTPS servers URLs on client!
const _socket = require('socket.io-client')(devUrl)
const _socket = require('socket.io-client/dist/socket.io.dev.js')(devUrl)
window.__dev_client__ = _socket

_socket.on('connect', function () {
Expand Down