feat(types): LangTag types languageName prop using LanguageName utility type
#388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
changed the title
LangTag types languageName prop using LanguageName utility type
metonym
force-pushed
the
langtag-languagename-type
branch
from
71586b2 to
37dc4a5
Compare
metonym
temporarily deployed
to
langtag-languagename-type - svelte-highlight PR #388
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#386 added a
LanguageNameutility type.Similar to #387, this applies the utility type to the
languageNameprop inLangTagto improve DX. The widened string literal union trick is used to afford autocomplete while allowing any string.This also adds an e2e test for
LangTag. Even thoughLangTagis an abstraction (not intended to be used directly), it's still worth adding a test case.