Adding "x-dbtype" to show database field type #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@VyseExhale : This is similar to your pull request. There are other places to add the x-dbtype. The reflect_type entry translates the MySQL numeric types to actual types. For now, the other db's will have to tweak the code to provide the full type translation (IE: SqlServer will show numbers for x-dbtype). Since we are just including an x-dbtype, this does not really impact the swagger 2.0 standard at the moment. I tested this against the MySQL test database and resultant json at swagger.io. It is fine. The unit tests for sqlite, postgresql and mysql pass.
It is a step in the right direction I think. Note the icon is really a binary data blob instead of a string. In actuality, I believe you deliver it as a string translated to hex?