Skip to content

Conversation

@zenonparker
Copy link
Contributor

As described in Issue #111

@mfontanini
Copy link
Owner

Thanks for this. This will break people's code but it won't work as it is so we have no choice. @accelerated heads up, not sure if you're using this outside of cppkafka.

@mfontanini mfontanini merged commit d3ef9ca into mfontanini:master Aug 30, 2018
@zenonparker zenonparker deleted the feature/zparker/fix111_rename_loglevel branch August 30, 2018 19:47
@accelerated
Copy link
Contributor

accelerated commented Aug 30, 2018

Well the alternative non-breaking solution would have been to #undef LOG_EMERG & others right above the LogLevel enum. That being said, I prefer the CamelCase enum names even if they're breaking code.

@mfontanini
Copy link
Owner

Right but then if you have an application that uses both syslog and cppkafka, then you'll have an issue when trying to use those macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants