Fix build on some libcxx implementations #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/topic_partition_list.cpp:91:30: error: use of undeclared identifier 'equal'; did you mean 'std::equal'?
bool match = equal(topic.begin(), topic.end(), partition.get_topic().begin(),
^~~~~
std::equal
../libs/cxxsupp/libcxx/include/algorithm:1215:1: note: 'std::equal' declared here
equal(_InputIterator1 __first1, _InputIterator1 __last1, _InputIterator2 __first2, _BinaryPredicate __pred)
^
1 error generated.
mfontanini
reviewed
Mar 7, 2019
Owner
|
Thanks! |
accelerated
pushed a commit
to accelerated/cppkafka
that referenced
this pull request
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/topic_partition_list.cpp:91:30: error: use of undeclared identifier 'equal'; did you mean 'std::equal'?
bool match = equal(topic.begin(), topic.end(), partition.get_topic().begin(),
^~~~~
std::equal
../libs/cxxsupp/libcxx/include/algorithm:1215:1: note: 'std::equal' declared here
equal(_InputIterator1 __first1, _InputIterator1 __last1, _InputIterator2 __first2, _BinaryPredicate __pred)
^
1 error generated.