Removed dependency from rdkafka since it has its own pkg_config file.… #199
Conversation
… Also added BITNESS detection
CMakeLists.txt
Outdated
| option(CPPKAFKA_RDKAFKA_STATIC_LIB "Link with Rdkafka static library." OFF) | ||
|
|
||
| # Determine if this is a 32 or 64 bit build | ||
| string(FIND ${CMAKE_CXX_FLAGS} "-m64" BITNESS) |
There was a problem hiding this comment.
Is there any guarantees there's actually going to be a -m64 in CXX_FLAGS? I've used something like this in the past to detect 32/64 bit architectures.
There was a problem hiding this comment.
Yes I think your proposal is more platform independent. How about something like this which is simpler? from the 2nd voted answer
math(EXPR BITS "8*${CMAKE_SIZEOF_VOID_P}")
set(BOOST_LIBRARY "/boost/win${BITS}/lib")
|
Done. Btw, for the versioning, perhaps you can bump to 1.0.0 since the sonames are not really matching. Also any plans to finish the admin API? |
|
Thanks! What do you mean the sonames aren't matching? I have a separate branch on the admin API stuff but I honestly don't have the time (or the willingness) to finish it now. It's actually mostly done I think. I was just missing something to encapsulate the message responses. Maybe I'll push myself to finish it some day soon. |
Sorry i meant the .so versions. Since your version was already tagged in github at a higher number (0.3.x) but your cmake was still building with 0.2 |
|
I might give it a go to complete the admin API since we will most likely need it in the near future. |
|
I already went back and fixed the sonames in 0.3.0 and 0.3.1, that was very broken.
Sounds good! Please let me know (comment on #119) when you do so we don't overlap in case I actually start working on it. |
|
sure |
3 participants
Description
cppkafka.pcsince rdkafka has its own pkg_config file and it would cause double linking which is unnecessary.cppkafka.pcfile.RequirestoRequires.privateand added comma separation between libs.