Fix crash when message handle is valid but topic is null #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain RdKafka errors such as
RD_KAFKA_RESP_ERR__TIMED_OUTwhen brokers are down or undiscoverable will cause RdKafka to raise the message receive callback with a valid message payload (it needs to contain the error number), however the key and partitions are null. IfMessage::get_topic()is called on such a message, this is delegated tord_kafka_topic_name(null)which unfortunately dereferences this pointer w/o checking and crashes.@mfontanini would be great if you can prioritize this. Thanks!