Conversation
This patch remedies a bug where a required map key could have a nil schematic, meaning set as the literal nil, but would be treated as if the key was optional, rather than specifying the value is nil exactly. This had downstream effects when used inside another schematic like the `oneof` schematic. If you had two map schematics as options, both with `nil` as the value schematic for its key, it would assume the first map unified, but was just missing its key. Now, map schematics with missing required keys will return errors with "is missing".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch remedies a bug where a required map key could have a nil
schematic, meaning set as the literal nil, but would be treated as if
the key was optional, rather than specifying the value is nil exactly.
This had downstream effects when used inside another schematic like the
oneofschematic. If you had two map schematics as options, both withnilas the value schematic for its key, it would assume the first mapunified, but was just missing its key.
Now, map schematics with missing required keys will return errors with
"is missing".