don't redefine HIDDEN/VISIBLE macros on MinGW #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Collaborator
|
It seems like you're invested in getting MinGW building cleanly... As I've said to others submitting patches for Windows, it'd be very helpful if you could add an example of your environment to GitHub actions, then we can ensure that things don't break between releases. |
Contributor
Author
|
I'd have to look into getting an MSYS2 CI setup. I've never done such a thing. I assume MSVC still has redefinition issues. I see libkqueue also has solaris support. Wonder if solaris has C11 atomics... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rosen Penev rosenp@gmail.com