Socket errors support #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to determine the actual socket error via SO_ERROR socket option. However, this system call does not work for descriptors other than sockets, and it'd be a total waste of time to call it just to get ENOTSOCK. In order to avoid the cost of the context switch, let's store some additional information from the times the knote was created. This change mostly deals with the Linux code only; likely the same changes can be applied to Windows as well. However, this issue is to be addressed by a separate commit.
Contributor
Author
|
I don't use cmake, so I had to spend some time investigating how to run the test. I invalidated some of the checks of KNFL_SOCKET_PASSIVE, and the best option seemed to make KNFL_SOCKET a bitwise OR of socket type flags. Once this change is applied, the test works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for more knote flags (we already invoke fstat(2) upon knote creation) and makes use for one of them to fetch the pending socket error.