This repository was archived by the owner on Sep 17, 2025. It is now read-only.
get image gallery working again #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takkaria
force-pushed
the
image-gallery
branch
from
0aeb451 to
f63535a
Compare
Contributor
Author
|
This has now been rebased onto master |
takkaria
force-pushed
the
image-gallery
branch
from
6c3f624 to
00d6855
Compare
Instead we calculate it ourselves on first save. This is to avoid Django re-calculating the values on every save, which requires access to the file. Since our images are effectively immutable, this isn't something we ever need to do, and it makes testing more difficult.
It's more of a rewrite than a refactor. It includes all the functionality of the previous PHP-backed image gallery but also: - looks nicer - displays all the photos in a grid - makes the 'edit note' functionality more visible - Boosts the size of clickable areas for usability (this is a bit hacky right now - but it works and can be refined later if/when there is a broader usability overhaul) - Uploads and deletes images in parallel It's also written in a very different style to the rest of the code, in a more modern JS features.
takkaria
force-pushed
the
image-gallery
branch
from
00d6855 to
c3d14b3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a big code dump, sorry about that, but it's reviewable commit-by-commit.
I would particularly like comments on the DRF code - I'm not very familiar with writing DRF views so I'm not sure if my style is right. Also whether factoring out of the assessment queryset to
helpers.pymakes sense.