FIX: featureFlags.set() does not update cached featureFlags #42

src/featureFlags.provider.js

@@ -23,6 +23,7 @@ function FeatureFlags($q, featureFlagOverrides, initialFlags) {
     updateFlagsAndGetAll = function(newFlags) {
       newFlags.forEach(function(flag) {
         serverFlagCache[flag.key] = flag.active;
+        featureFlagOverrides.set(flag.key, flag.active);
         flag.active = isOn(flag.key);
       });
       angular.copy(newFlags, flags);

test/featureFlags.provider.spec.js

@@ -352,6 +352,28 @@
         });
       });
     });
+
+    describe('when I enable a flag and then set the list of flags with the same flag', function() {
+      var flagKey = 'FLAG_KEY';
+      var onFlag = {
+        active: true,
+        key: flagKey
+      };
+      var offFlag = {
+        active: false,
+        key: flagKey
+      };
+
+      beforeEach(function() {
+        featureFlags.enable(onFlag);
+
+        featureFlags.set([offFlag]);
+      });
+
+      it('should override previous flag value', function() {
+        expect(featureFlags.isOn(flagKey)).toBe(false);
+      });
+    });
   });
 
   describe('Provider: featureFlags', function() {