-
Notifications
You must be signed in to change notification settings - Fork 0
Handle type aliases better #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to improve the handling of type aliases and enhance consistency throughout type resolution.
- Added explicit alias names (e.g. "TupleType", "NamedTupleType", "Parameters") in test output JSON files to better represent type aliases.
- Refactored parser functions (resolveType, parseProperty, parseObjectType, etc.) to remove redundant parameters and streamline type resolution.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/tuples/output.json | Added alias names for tuple types. |
| test/ts-utility-types/output.json | Added alias name "Parameters". |
| test/react-refs/output.json | Updated reference nodes to include "React" in parentNamespaces. |
| test/namespaces/output.json | Added/updated alias names and namespaces for union types. |
| test/namespaces/input.tsx | Introduced type alias "NamespacedType" for improved alias usage. |
| test/mui-overridable-component/output.json | Altered alias names for CSS-related types. |
| test/hook-/.json | Updated react ref alias handling. |
| test/generics-closed/* | Introduced deeper alias handling in generics tests. |
| test/base-ui-component/output.json | Renamed alias from "GenericHTMLProps" to "Props". |
| test/arrays/output.json | Specified alias name "Array" for array outputs. |
| test/aliases/* | Added tests for alias resolution and record type handling. |
| src/parsers/typeResolver.ts | Removed redundant "name" parameter and centralized alias logic. |
| src/parsers/propertyParser.ts | Updated resolveType calls with typeNode when available. |
| src/parsers/objectParser.ts | Refactored property filtering and naming consistency. |
| src/parsers/functionParser.ts | Updated resolveType usage in function signature parsing. |
| src/parsers/exportParser.ts | Removed redundant name references in export parsing. |
cb93427 to
43ccbe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.