Enhancement: Resolver option defaultAttributes
#184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
you're welcome to update .eslintrc |
Contributor
Author
|
Ok, great, I'll add some rules to |
Owner
|
LGTM, i would appreciate a squash to a few more descriptive commits. |
Contributor
Author
|
Will do. |
(1) .eslintrc: Ignore testing globals Mocha globals like `it` & `describe` trigger eslint warnings because they are not imported explicitly. Setting them as `globals` in .eslintrc fixes that. (2) Make eslintrc compatible with chai assertion expressions There is no way to make eslint shut up about chai's assertion expressions (`expect(foo).to.be.true`) without disabling this rule. See eslint/eslint#2102 (3) Lint resolver.test.js
There were two flaky tests, both related to assertions on specific orderings of arrays. One case expected the order of `user.task` to be deterministic which is not the case, the other expected the order of the graphql schemas `users` field response to be deterministic. The issues were fixed by just asserting that members of the compared arrays were deep equal.
Contributor
Author
|
I squashed it. |
mickhansen
added a commit
that referenced
this pull request
Mar 18, 2016
Enhancement: Resolver option `defaultAttributes`
Owner
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #172, i've implemented the resolver option
defaultAttributes.I also fixed the flakyness issue in
resolver.test.jsby not asserting on the order of the compared arrays in two cases.I wasn't entirely sure about some code style issues that are not answered by the
.eslintrc:var foo = require('...') vsimport ...`constvs.var?function()?It might be a good idea to provide more strict guidance per
.eslintrcfor a more homogenous code look and feel -- I spent the majority of time thinking about those issues and how to "fit in" to the existing code style(s). :)