1000 model rna library preparation #2113
Conversation
Option 1 for modeling, separating concepts of stranded vs non stranded and then stranded orientation.
Model rna types in a single enumeration.
…ration_rna_option2.yaml Update file name
|
|
Thanks @aclum! I prefer the explicitness and atomicity of the |
Deleting this modeling example in favor of modeling strandedness and strand orientation separately.
Addes slots for rna library preparation
aclum
requested review from
naglepuff,
sujaypatil96,
mslarae13,
mbthornton-lbl,
chienchi,
scanon and
eecavanna
There was a problem hiding this comment.
Changes are additive, no migrators needed.
I agree. This schema change adds a non-required slot named is_stranded to an existing class, adds a non-required slot named stranded_orientation (whose range is an enum) to that same class, and defines that enum. None of that has the potential to make currently-valid data become invalid, which is what I consider to be the condition for whether a migrator is necessary or not.
I'm requesting a couple changes related to the spelling of "orientation". I don't have any other concerns about the changes in this PR.
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
|
Discussed at the workflows meeting and there were no concerns. |
Updates to metatranscriptome library prep enumerations.
This PR is to model how to capture RNA-seq library preparation information which is needed input for the expression step of the Metatranscriptome analysis workflow.
This adds two slots which are applied to Class LibraryPreparation.
Changes are additive, no migrators needed.