Dialog warnings for using MakeCode with a V1 #358
Conversation
|
Preview build will be at |
|
Some changes to messages/ui.en.json are the result of running the i18n compile step and not directly related to this PR. |
| // Open editor if device is not a V1, otherwise show warning dialog. | ||
| const bluetoothConnection = getBluetoothConnection(); | ||
| if (bluetoothConnection) { | ||
| if (bluetoothConnection.getBoardVersion() === "V1") { | ||
| return onOpen(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Might be nice to hide the bluetooth-specific nature of this behind something in the hook as we might do V1 radio bridge at some point.
There was a problem hiding this comment.
Done here. A bit more work to hold on to the radio remote board version 5dc85ea
radioRemoteBoardVersion is currently not cleared if you go back to the home page and start a new session. It's only cleared on a page refresh.
There was a problem hiding this comment.
We're going to ponder this on a separate ticket.
This should also work for the remote device when using radio bridge.
microbit-matt-hillsdon
changed the title
|
Just waiting on copy feedback now, otherwise LGTM. |
|
Copy feedback not likely in time for beta, gone with best guess and will tweak later. |
No description provided.