Add Action Threshold to the model header. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-carlos
force-pushed
the
threshold
branch
from
2db90fa to
6c74409
Compare
microbit-carlos
force-pushed
the
threshold
branch
from
6c74409 to
868857d
Compare
microbit-robert
approved these changes
Jun 11, 2024
Collaborator
microbit-robert
left a comment
microbit-robert
left a comment
There was a problem hiding this comment.
LGTM. I've tested this with the bundled autogenerated.ts file and without code generated via the editor extension using changes made in this PR https://github.com/microbit-foundation/makecode-ml-editor-extension-poc/pull/3. I'll merge once other affected branches are ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the header to also include thresholds for each action.
This PR will need an update to https://github.com/microbit-foundation/makecode-ml-editor-extension-poc to update the included package, or pick it up from GH's package registry: