Fix for image responsiveness #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
| */ | ||
| export const docStyles = { | ||
| "p,img": { | ||
| "p,h3": { |
Collaborator
There was a problem hiding this comment.
Just h3 felt arbitrary but it is correct, the content doesn't permit any headings and the toolkit entry headings are h3s.
Just commenting FTR, no action.
microbit-matt-hillsdon
approved these changes
Apr 22, 2022
Collaborator
microbit-matt-hillsdon
left a comment
microbit-matt-hillsdon
left a comment
There was a problem hiding this comment.
Looks good, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows toolkit images to shrink below their set widths preventing the reference tab layout issue referenced below.
Closes #707