Move the beta notice to a flag. #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable it for non-production stages. This removes livePreview. To get the same effect you need to do flag=none.
|
Preview build will be at |
Collaborator
Author
|
Tempted to remove the ability to enable all flags. As we use them more for environment differences like this it'll cease to make sense. |
Collaborator
Yep, that makes sense. I don't remember the last time I used |
microbit-robert
approved these changes
Sep 13, 2022
Collaborator
microbit-robert
left a comment
microbit-robert
left a comment
There was a problem hiding this comment.
One minor comment, otherwise this looks good. Also in favour or removing the all flags flag.
Collaborator
Author
I'll do this separately at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable it for non-production stages.
This removes livePreview. To get the same effect you need to do flag=none.
We can merge this now, no need to wait for the release.