Skip to content

Conversation

@JesuTerraz
Copy link
Contributor

  • Makes authToken optional. If not provided, the registration service will attempt to authenticate using Agents SDK agentic auth

Copilot AI review requested due to automatic review settings November 3, 2025 21:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds default empty string values to the authToken parameter across three MCP tool registration service implementations. This change ensures the parameter is optional while maintaining backward compatibility.

  • Changed the authToken parameter to have a default value of empty string in three service classes
  • Maintains existing logic that fetches a token if none is provided
  • Applies the same pattern consistently across OpenAI, LangChain, and Claude extensions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/agents-a365-tooling-extensions-openai/src/McpToolRegistrationService.ts Added default empty string value to authToken parameter in addMcpToolServers method
packages/agents-a365-tooling-extensions-langchain/src/McpToolRegistrationService.ts Added default empty string value to authToken parameter in addMcpToolServers method
packages/agents-a365-tooling-extensions-claude/src/McpToolRegistrationService.ts Added default empty string value to authToken parameter in addToolServers method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants