Add Java 11 to smoke test matrix #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Aug 26, 2019
trask
commented
Aug 26, 2019
trask
force-pushed
the
trask/add-java-11-to-build-matrix
branch
from
be49ae0 to
a15f758
Compare
littleaj
reviewed
Aug 26, 2019
test/smoke/testApps/SpringBootTest/src/smokeTest/resources/jre.excludes.txt
Show resolved
Hide resolved
littleaj
reviewed
Aug 26, 2019
Contributor
littleaj
left a comment
littleaj
left a comment
There was a problem hiding this comment.
LGTM, but I want to discuss the java7 coverage before approving
trask
force-pushed
the
trask/add-java-11-to-build-matrix
branch
from
166e550 to
fbbe8a0
Compare
littleaj
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.