-
Notifications
You must be signed in to change notification settings - Fork 208
Update changelog for 3.4.17 #3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
91b0873
Update changelog for 3.4.17
heyams 9ff7c9b
Update
heyams e1a2f4b
Comments
heyams 1e14d17
Fix wrong year in date
heyams 21cffbb
Update CHANGELOG.md
trask 5d9dc91
Update CHANGELOG.md
trask 1815065
Merge remote-tracking branch 'origin/main' into heya/release-3.4.17
trask 12f0e49
fix
trask File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,8 +10,6 @@ | |
| import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_20; | ||
| import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_8; | ||
| import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_8_OPENJ9; | ||
| import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.WILDFLY_13_JAVA_8; | ||
| import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.WILDFLY_13_JAVA_8_OPENJ9; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
@@ -50,9 +48,5 @@ static class Tomcat8Java19Test extends SamplingOverridesThreadName {} | |
| @Environment(TOMCAT_8_JAVA_20) | ||
| static class Tomcat8Java20Test extends SamplingOverridesThreadName {} | ||
|
|
||
| @Environment(WILDFLY_13_JAVA_8) | ||
| static class Wildfly13Java8Test extends SamplingOverridesThreadName {} | ||
|
|
||
| @Environment(WILDFLY_13_JAVA_8_OPENJ9) | ||
| static class Wildfly13Java8OpenJ9Test extends SamplingOverridesThreadName {} | ||
| // intentionally not including wildfly, since this test is set up for Tomcat thread names | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @heyams I'm not sure how this test passed is passing sometimes on wildfly (I couldn't get it to pass locally), but I think ok to just only test on Tomcat |
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.