Skip to content

Reliable channel: replacing logAlways "TRACE" statements with "info" #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Reliable channel: replacing logAlways "TRACE" statements with "info" #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...m/microsoft/applicationinsights/internal/channel/common/TransmissionFileSystemOutput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public TransmissionFileSystemOutput(String folderPath) {
@Override
public boolean send(Transmission transmission) {
if (size.get() >= capacityInKB) {
InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.WARN, "Persistent storage max capcity has been reached; currently at %s KB. Telemetry will be lost, please set the MaxTransmissionStorageFilesCapacityInMB property in the configuration file.", size.get());
InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.WARN, "Persistent storage max capacity has been reached; currently at %s KB. Telemetry will be lost, please set the MaxTransmissionStorageFilesCapacityInMB property in the configuration file.", size.get());
return false;
}

Expand All @@ -152,7 +152,7 @@ public boolean send(Transmission transmission) {
return false;
}

InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.TRACE, "Persistent storage saved permanent file; data will be persisted and sent when the network is available.");
InternalLogger.INSTANCE.info("Data persisted to file. To be sent when the network is available.");
return true;
}

Expand Down
12 changes: 6 additions & 6 deletions .../com/microsoft/applicationinsights/internal/channel/common/TransmissionPolicyManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ public void backoff() {
long backOffMillis = backoffManager.backOffCurrentSenderThreadValue();
if (backOffMillis > 0)
{
long backOffSeconds = backOffMillis / 1000;
InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.TRACE, "App is throttled, telemetry will be blocked for %s seconds.", backOffSeconds);
this.suspendInSeconds(TransmissionPolicy.BACKOFF, backOffSeconds);
long backOffSeconds = backOffMillis / 1000;
InternalLogger.INSTANCE.info("App is throttled, telemetry will be blocked for %s seconds.", backOffSeconds);
this.suspendInSeconds(TransmissionPolicy.BACKOFF, backOffSeconds);
}
}

Expand All @@ -124,7 +124,7 @@ public void backoff() {
public void clearBackoff() {
policyState.setCurrentState(TransmissionPolicy.UNBLOCKED);
backoffManager.onDoneSending();
InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.TRACE, "Backoff has been reset.");
InternalLogger.INSTANCE.info("Backoff has been reset.");
}

/**
Expand Down Expand Up @@ -181,7 +181,7 @@ private synchronized void doSuspend(TransmissionPolicy policy, long suspendInSec
policyState.setCurrentState(policy);
suspensionDate = date;

InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.TRACE, "App is throttled, telemetries are blocked from now, for %s seconds", suspendInSeconds);
InternalLogger.INSTANCE.info("App is throttled, telemetries are blocked from now, for %s seconds", suspendInSeconds);
} catch (Throwable t) {
InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.ERROR, "App is throttled but failed to block transmission exception: %s", t.getMessage());
}
Expand All @@ -194,7 +194,7 @@ private synchronized void cancelSuspension(long expectedGeneration) {

policyState.setCurrentState(TransmissionPolicy.UNBLOCKED);
suspensionDate = null;
InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.TRACE, "App is throttled is cancelled");
InternalLogger.INSTANCE.info("App throttling is cancelled.");
}

private synchronized void createScheduler() {
Expand Down