Corrected wording of Root PF Serving Hierarchy #2469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section is called 'Root Public Folder Mailbox Serving Hierarchy' and we had the values backwards due to the property being IsExcludedFromServingHierarchy
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lusassl-msft
approved these changes
Oct 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the logic for reporting the Root Public Folder Mailbox serving hierarchy status. The changes fix inverted boolean values to properly indicate when the root public folder mailbox is incorrectly serving the hierarchy.
- Corrects the default
$detailsvalue from$trueto$falseto represent proper excluded state - Fixes the error case
$detailsvalue from string"false - Error"to"true - Error"to accurately reflect that the mailbox is serving the hierarchy when it shouldn't
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Diagnostics/HealthChecker/Analyzer/Invoke-AnalyzerFrequentConfigurationIssues.ps1
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The section is called 'Root Public Folder Mailbox Serving Hierarchy' and we had the values backwards due to the property being
IsExcludedFromServingHierarchy.Reason:
When we have the issue, we need to provide
trueinstead offalsebecause the Root Public Folder Mailbox is serving the hierarchy, when it shouldn't be. The setting needs to be set to true, which isIsExcludedFromServingHierarchy.Fix:
Corrected the wording.
Validation:
N/A