Unflag object rest/spread.#6130
Merged
Merged
Conversation
Contributor
|
nice - LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Jun 4, 2019
Merge pull request #6130 from zenparsing:enable-obj-rest-spread For reference: - Object spread PR: #5268 - Object rest PR: #5498 The functionality is implemented in the JIT using helper calls. For destructuring rest, it uses GC'd arrays for tracking which computed property names have already been pulled out of the object. A PR exists for updating our fuzzers to generate the new syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reference:
The functionality is implemented in the JIT using helper calls. For destructuring rest, it uses GC'd arrays for tracking which computed property names have already been pulled out of the object.
A PR exists for updating our fuzzers to generate the new syntax.