Implement well-formed JSON.stringify#6206
Merged
Merged
Conversation
zenparsing
approved these changes
Jul 22, 2019
Contributor
|
Can you check perf of JSON tests in kraken? This adds 2 branches into a tight loop so I'm a little concerned that it will cause regressions. |
Contributor
Author
|
@MikeHolman I had the same concern but it doesn't look like |
MikeHolman
approved these changes
Jul 22, 2019
The change to the spec makes unpaired surrogate code units serialize to their escape sequences instead of bad characters. This is now in stage 4. Fixes chakra-core#5735
boingoing
force-pushed
the
wellformedjson
branch
from
f1edeb9 to
8d4374c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to the spec makes unpaired surrogate code units serialize to their escape sequences instead of bad characters.
This is now in stage 4.
Fixes #5735